Repository navigation
Run deterministic tasks with explicit trust and frozen acceptance (#333) - #336
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfd23d3bf0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
First-pass review by oxa → oxc → Codex findings
Additional findings
TIER: T3 🤖 Generated with Claude Code (oxa review lane) |
|
First-pass review by oxa → oxc → Codex findings
New findings
TIER: T2 🤖 Generated with Claude Code (oxa review lane) |
|
Addressed the latest first-pass REVISE at 6915352 (normal merge through current main). The parent offline policy now reaches every child, including an explicit Task setup errors now emit a blocked JSON line, preserve any existing receipt/active task state, and continue the batch; they return aggregate exit 1. The failing-first two-task regression confirms the second task executes. Locks now use kernel ownership on a stable inode, so a file abandoned by a killed runner does not block forever; its failing-first regression is green. The earlier real-bwrap commit and both offline issue-fetch regressions remain green. All 171 touched-crate tests, formatting, strict all-target clippy and unchanged four CI scans pass. The restart checkpoints in step 3 build on these fixes; no review wait. |
|
First-pass review by oxa → oxc → Codex findings
New findings
TIER: T2 🤖 Generated with Claude Code (oxa review lane) |
|
The latest first-pass REVISE at 6915352 is fixed at d7ab5cf, now normally merged through main at e8952cb. Command recognition after options is restricted to the explicit |
|
First-pass review by oxa → oxc → Codex findings
New findings
TIER: T3 🤖 Generated with Claude Code (oxa review lane) |
|
The new acceptance sandbox/trust findings are valid: freezing command text does not constrain agent-edited scripts/tests. I have identified the fix path: require the existing project-trust decision and execute acceptance through the normal Bwrap policy in a separate supervisor that retains the task lock, keeping acceptance external to the model. This implementation is parked under #331's new owner priority while I take Rust skeleton job (a); the REVISE remains outstanding. The P3 concerning green checks after a nonzero repair-agent exit is intentional: the documented blocked outcome includes agent execution failure. Check success alone does not erase a failed agent process. The state/worktree remain retained. |
|
Parked as draft while the acknowledged acceptance sandbox/trust P1s remain unfixed. This prevents it being treated as ready to merge during #331's Rust-skeleton priority. All runner implementation and test evidence are saved; no queued branch was touched. The priority work is now skeleton (a), #428. |
|
The outstanding acceptance sandbox/trust P1s are fixed at ccf2550 after a normal main merge. Both exploit regressions failed before the fix: untrusted source commands executed, and an agent-written check escaped through HOME. They now run through the existing shared trust/content approval and normal Bwrap policy, including read-only executable Git configuration; missing Bwrap blocks. Private runner state is outside writable Git binds, and worker/check supervisors retain the task lock. #332's exit/oxa_result/session contract is consumed, with same-session repair and no repair spend after a budget block. All 230 touched tests, strict checks, docs and four unchanged scans pass. The conservative blocked outcome for a failed worker remains intentional. This head stays draft until its own new gate is green. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccf2550fd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
First-pass review by oxa → oxc → Codex findings
🤖 Generated with Claude Code (oxa review lane) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12341d2092
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
First-pass review by oxa → oxc → Codex findings
🤖 Generated with Claude Code (oxa review lane) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 224b4fef12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
First-pass review by oxa → oxc → Codex findings
TIER: T3 🤖 Generated with Claude Code (oxa review lane) |
|
Independent second security read at
Checked and sound: absolute, validated Missing tests: multi-task ref or replace tampering; a parent-trusted or Held until 1 and 2 are fixed with tests. This is the foundation for unattended runs on untrusted repositories, so the extra round is worth it. 🤖 Generated with Claude Code |
|
Addressed the independent second read in 7d81cd5:
All 254 touched tests / 47 runner cases, strict all-target Clippy/fmt, links and unchanged scans pass. The ten new regressions failed first. The PR is draft for this new head's own gate; #358/#387 will be re-cut on main after their parents land, with the event hook/revision at the front of #387. |
|
Second security read, re-check at
🤖 Generated with Claude Code |
Delivers step 1 of #333: one child worker per task in a retained Git worktree. Coordination uses files, Git and typed child results; the runner starts no daemon and spends no model tokens.
Before any checkout or worker starts, the runner validates and snapshots every task's literal branch, base SHA and acceptance commands. Each receipt records that base SHA. Later workers cannot change a planned task by moving a shared ref or creating a replacement ref. Host Git commands clear inherited GIT_* overrides, ignore replacement objects, disable fsmonitor and refuse all transport/lazy fetching, including repository-configured promisor helpers.
Source repositories pass normal project-trust and executable-content approval. Worker starts and same-session repairs explicitly use -na and remove OXA_TRUST_PROJECT: a parent-directory decision, defaultProjectTrust=always or inherited approval flag cannot load a different base's project settings, MCP servers or extensions. User-level resources retain normal behavior. External checks use the approved source and the frozen batch command list.
Worktree bootstrap creates detached metadata without host callbacks. Actual branch creation, checkout hooks, reference hooks and filters run in the normal Bwrap supervisor; rejecting reference hooks still refuse branch creation. Missing bwrap blocks before a worker starts. Configured hook directories retain read-only protection; checkout of a tracked protected hook directory blocks and retains the worktree. Final inspection is read-only/offline, ignores replacement objects and fsmonitor, and returns its clean/dirty verdict by exit code.
The worker contract records oxa_result, OS exit and session ID, drains output with bounded buffers, and preserves worker/check failures. Failed/blocked/interrupted workers consume no repair call. One repair after failed acceptance continues the saved session. Private locks and receipts live outside writable Git/worktree binds (0700 directories, 0600 files). Receipts use a durable temporary file and atomic create-only linking; interrupted writes cannot expose an empty canonical receipt. Worktrees remain available after every outcome.
Local done can include uncommitted work. This slice does not publish. Commit/tree/base binding and acceptance on a clean committed export are required in the saving/publication slices before #397 can push. Worker deadline/stall handling follows the coordinated worker-status/L1 contract.
Measured against main 764e639 at the same build path, x86_64 stripped ci profile, Rust 1.100.0, three isolated synthetic loopback samples per mode:
T3. At 7d81cd5: 254 touched-crate tests, including 47 real-child/bare-repository runner cases, pass with mandatory nested Bwrap and isolated homes. Twenty-four regressions were observed failing before fixes. New cases reproduce inherited/default/environment/repair trust, cross-task ref and replace-ref forgery, partial-clone host execution, Git environment redirection, branch aliases and a receipt-write crash. Existing callback, offline, trust, budget, same-session and bounded-output controls remain green. Strict all-target Clippy, workspace fmt, changed-doc links and all four unchanged CI scans pass. Own-head draft gate 43839602395 and full ready gate 43840375867 are green, including mandatory-bwrap workspace/inventory validation and CodeQL. This PR is ready for external re-review/landing. Later slices will be re-cut on main after their parents land.